On Sun, 15 May 2005, Rafael Martinez Torres wrote:
> Tag: squid3-ipv6
> config.h
>
> +#define NEEDS_BRACKETS(s) \
> + SAFE_INET_ADDR(s,NULL)
> +
Just curious, but what is the rationale behind this macro?
Brobably also needs a better name... NEEDS_BRACKETS is pretty generic and
not obviously associated with networking.
Another comment on general style: Try to avoid macros in C++ unless
absolute needed. Inlined functions generally serves the purpose just as
good in terms of performance and additionally is type safe and does not
pollute the name space as badly.
Regards
Henrik
Received on Sun May 15 2005 - 10:09:13 MDT
This archive was generated by hypermail pre-2.1.9 : Tue May 31 2005 - 12:00:03 MDT