Re: url size problem

Rob,
please ignore my previous email. It is fixed.
I forgot to do another allocation if the request need to be redirected.
Now valgrind shows no errors.

Thanks.

On 1 Aug 2003, Robert Collins wrote:

> On Fri, 2003-08-01 at 15:31, Songqing Chen wrote:
> > hi, guys,
> >
> > since I need to re-write the url inside with some suffix, so in function
> > parseHttpRequest(...)
> >
> > /* URL may be rewritten later, so make extra room */
> > url_sz = strlen(url) + Config.appendDomainLen + 5;
> > http->uri = xcalloc(url_sz, 1);
> > strcpy(http->uri, url);
> >
> > I add an additional 10.
> >
> > However, sometimes the system can catch Segment Fault, for invaild memory
> > refernce when it tries to free(http->uri).
> >
> > I guess the problem is from this, but not sure. Anyone has any idea on
> > this?
>
> It's probably better to use the external redirector interface rather
> than altering the url internally - it's already well tested and stable.
>
> That said, you should be able to identify the problem using gdb or
> valgrind / memcheck.
>
> Cheers,
> Rob
>
>

-- 
Chen,Songqing
Dept. of Computer Science
College of William&Mary