Re: latest merge raises compile warnings

Hmm.. I do not seem to get any such warnings in my current tree now when
the rproxy merge is near completetion, but do not remember fixing them
either... odd.

In any event, if you see warnings or other obvious errors in code I have
committed, please fix them immediately. Don't worry if it might conflict
with other changes I may have in the pipeline (my problem).

I am currently testing the last parts of the rproxy merge. This will be
committed tomorrow.

Have not yet had time to look into the missing comm callback queue
cbdata fences, but hope to do so in the next few days after the rproxy
merge is done.

The rproxy merge backs out some of the minor request parsing refactoring
you had done, and some of this should probably be redone.

Also, there is some parts of the code (http_port/https_port) which
really SHOULD be rewritten to use classes with inheritance.. bastard C
code at the moment.

The code is temporarily in the rproxy branch while testing as I am not
entirely sure if this refactoring should be done before committing to
HEAD or after..

Regards
Henrik

Henrik Nordstrom wrote:
>
> Please fix. Not intentional to break HEAD. I thought I tried to compile
> all changes before commit, but obviously forgot to test this part. Sorry
> about this.
>
> My tree is in the middle of the next (much larger) rproxy merge and it
> will take some time before it compiles again.
>
> However, it would be nice if you could wait a few days with any changes
> relating to
>
> - request parsing
> - http/https_port
> - acceleration related config or flags
> - IP interception
>
> as these areas are heavily touched by the final "real" merge from rproxy
> (for this time).
>
> Regards
> Henrik
>
> Robert Collins wrote:
> >
> > in cache_cf.cc - *_peer..
> >
> > Let me know if you want me to do the obvious thing. I won't until I hear
> > from you, incase this is temporary until your next rproxy merge.
> >
> > Rob
> >
> > --
> > GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.
> >
> > ------------------------------------------------------------------------
> > Name: signature.asc
> > signature.asc Type: application/pgp-signature
> > Description: This is a digitally signed message part
Received on Sun Feb 16 2003 - 16:06:07 MST