Re: What is the purpose of conn->flags.readMoreRequests?

On Mon, 2003-02-10 at 07:51, Henrik Nordstrom wrote:
> Robert Collins wrote:
>
> > It was created while attacking the huge and obtruse client request
> > reqading logic, to help factor it up. If it has become less useful, and
> > can be factored away, coool.
>
> I think so. You also have the context->mayUseConnection flag which
> serves the same purpose where it is needed in request processing. The
> rest should be derived from reply processing..

As long as keep heading to more targeted functions, not the goliath 500
things in one function we had there :}.

> > The main point was to mark the connection as being not allowed to read
> > requests. This would happen when SSL or posts where detected.
>
> For which it does not actually work as the filedescriptor is still
> polled.. this bite me in the CONNECT processing as
> !conn->flags.readMoreRequests had a higher priority than
> context->mayUseConnection and caused the filedescriptor to continue to
> be polled and read requests from..

AH. eek.

Rob

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.