Re: Windows port merge - Various include file changes [PATCH]

Hi Robert,

Il 14.42 02/02/2003 Robert Collins ha scritto:
>On Mon, 2003-02-03 at 00:19, Guido Serassio wrote:
> > Hi,
> >
> > This is the second of some splitted native Windows patches grouped by
> > functionality.
> >
> > This patch add the native Windows support for profiling and fix some C++/C
> > include files problems.
>
>
>I'm not sure this is correct:
>in util.h, should it not be:
>
>#if HAVE_SYS_PARAM_H
>#include <sys/param.h>
>#endif
>#ifndef _SQUID_MSWIN_
>...
>#endif
>
>?

On MS Visual Studio there is no sys/param.h, but in MinGW yes.
So this should be better (Just tested):

#if !defined(SQUIDHOSTNAMELEN)
#if !(defined(_SQUID_MSWIN_) && defined(_MSC_VER)) /* sys/param.h is not
available on MS Visual Studio */
#include <sys/param.h>
#endif
#ifndef _SQUID_MSWIN_ /* netdb.h is not available on MS Visual
Studio and MinGW */
#ifndef _SQUID_NETDB_H_ /* need protection on NEXTSTEP */
#define _SQUID_NETDB_H_
#include <netdb.h>
#endif
#endif

Regards

Guido

>The rest of the patch looks good. Please get back to me with whether
>this alteration works..
>Rob
>--
>GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

-
=======================================================
Serassio Guido
Via Albenga, 11/4 10134 - Torino - ITALY
E-mail: guido.serassio@serassio.it
WWW: http://www.serassio.it
Received on Sun Feb 02 2003 - 07:02:40 MST