Re: README and squid.conf generation

On 19 Aug 2001 11:13:12 +0200, Guido Serassio wrote:
> Hi,
>
> Il 10.52 19/08/2001 Robert Collins ha scritto:
> >On 19 Aug 2001 10:21:06 +0200, Guido Serassio wrote:
> > > Hi,
> > >
> > > Il 16.04 18/08/2001 Robert Collins ha scritto:
> > > >Well folk, here's my first set of stuff I'd like to check in:
> > > >
> > > >Changelog for readme.patch:
> > > > * README: Change the squid-users mailing to the new address.
> > > >
> > > >Changelog for squidconfname.patch:
> > > > * src/Makefile.in: Change build dir squid.conf to
> > > > squid.conf.default -
> > > >it is more accurate.
> > > > * src/cf_gen.c: Ditto.
> > > >
> > > >Any objections?
> > >
> > > Only a doubt:
> > >
> > > In this manner, after a "make install" command on a new installation,
> > Squid
> > > is no more ready to run, because there is no squid.conf file.
> >
> >Yes there is:
> >prechange: in the build dir there is squid.conf, make install installs
> >that as squid.conf.default, and if there is no squid.conf installs it as
> >squid.conf
> >postchange: in the bulid dir there is squid.conf.default. That always
> >gets installed, and optionally installs a copy as squid.conf - if there
> >is no conf file already.
> >
> > > So, we must change all on-line docs ......, see FAQ 3.2 & 3.4.
> > >
> > > What about adding a check for squid.conf, and if it's not found, copy
> > > squid.conf.default as squid.conf too ?
> >
> >It's already there :}
> >
> >Rob
>
> OK, if this is the wanted behaviour , looking on cvsweb on
> www.squid-cache.org, I think there is an error:
>
> $(INSTALL_FILE) squid.conf.default $(sysconfdir)/squid.conf.default
> @if test -f $(sysconfdir)/squid.conf ; then \
> echo "$@ will not overwrite existing
> $(sysconfdir)/squid.conf" ; \
> else \
> echo "$(INSTALL_FILE) squid.conf.default $(sysconfdir)"; \
> $(INSTALL_FILE) squid.conf.default $(sysconfdir); \ <==
> $(sysconfdir)/squid.conf; ????
> fi

Thanks Guido, nice catch there.

Fixed and committed.

Rob
Received on Sun Aug 19 2001 - 03:36:35 MDT