Re: PATCH: CygWin port enhancement - 2nd revision

On 15 Aug 2001 11:50:17 +0200, Guido Serassio wrote:
> Hi,
>
> This patch allows squid to use the hosts file from the right Windows
> directory when /etc/host is not found.
> The same stuff can be make in squid.conf, but with this patch the things
> are automatic at runtime, so multi boot installations can be more easily
> supported.
> Works on all supported WIN32 platforms (9x, NT, 2000 and XP).
>
> Other changes:
>
> - Better GetOSVersion function, more squid "aware", added support for
> Windows XP and future Windows versions.
> - Added trap in WIN32_Subsystem_Init() for unknown or unsupported (WIN32s)
> Windows version.
> - Fixed compile warning in comm.c
> - Changed exit() WIN32 hook, now less intrusive
>
> Can it please go into HEAD? Everything is #ifdef'd or otherwise protected.

Last thing:
@@ -39,37 +38,40 @@
{
     OSVERSIONINFO osvi;

+ xfree(WIN32_OS_string);
     memset(&osvi, '\0', sizeof(OSVERSIONINFO));

you should probably use safe_free instead of xfree. Other than that IMO
it's ready for HEAD inclusion.

Rob

> Guido
>
>
> -
> =======================================================
> Serassio Guido
> Via Albenga, 11/4 10134 - Torino - ITALY
> Tel. : +39.011.610749
> E-mail: serassio@interfree.it
> serassio@libero.it
> WWW: http://www.serassio.it
Received on Wed Aug 15 2001 - 06:52:55 MDT