Re: PATCH: CygWin port enhancement

Hi Robert,

Il 00.00 15/08/2001 Robert Collins ha scritto:
>On 14 Aug 2001 18:22:50 +0200, Guido Serassio wrote:
> > Hi,
> >
> > This patch allows squid to use the hosts file from the right Windows
> > directory when /etc/host is not found.
> > The same stuff can be make in squid.conf, but with this patch the things
> > are automatic at runtime, so multi boot installations can be more easily
> > supported.
> > Works on all WIN32 platforms.
> >
> > Other changes:
> >
> > - Better GetOSVersion function, more squid "aware".
> > - Fixed compile warning in comm.c
> > - Changed exit() WIN32 hook, now less intrusive
> >
> > Can it please go into HEAD? Everything is #ifdef'd or otherwise protected.
>
>Looks good to me. Nice work Guido.
>
>One teeny comment - cygwin doesn't run on win3.1/win32s - so unless you
>are planning a win3.1/win32s port youself that code OS could/should be
>treated as unknown :}.
>
>Rob

Now WIN32s is correctly recognized from GetOSVersion (In theory ..., who
has a Windows 3.1 with WIN32s ???).

If You think that can be useful, i can simply add a check for it in
WIN32_Subsystem_Init and abort the startup of Squid (If Cygwin doesn't
abort before ...).

Let me to know Your opinion.

Guido

-
=======================================================
Serassio Guido
Via Albenga, 11/4 10134 - Torino - ITALY
Tel. : +39.011.610749
E-mail: serassio@interfree.it
         serassio@libero.it
WWW: http://www.serassio.it
Received on Tue Aug 14 2001 - 16:09:56 MDT