Re: move xrename function [PATCH]

On 13 Aug 2001 14:43:45 +0200, Guido Serassio wrote:
> Hi Robert,
>
> Il 13.38 13/08/2001 Robert Collins ha scritto:
> >On 13 Aug 2001 09:57:26 +0200, Guido Serassio wrote:
> > > Hi Robert,
> > >
> > > >
> > > >It uses a different call tree to rotate cache.log which results in
> > > >xrename being used. Could you see if it works for you?
> > >
> > > Can you check if pinger on external_logger branch link without errors ?
> > >
> > > The reason because i move xrename in debug.c, is that pinger is linked
> > > against debug.o, so may be there are some unresolved functions from
> > logfile.c.
> >
> >Why does pinger.exe call the log rotate function? Your linker shouldn't
> >need to resolve the symbols for non-used functions. Ah well. If it
> >doesn, it does.
>
> Sorry, but I have wrong explained the problem:
>
> pinger (generic, non cygwin), use debug on debug.c, so if we include in
> debug.c call to external functions, we can have undefined reference errors.

Ah yes, I see now. (Mentally slaps own forehead). I've updated the
external logging branch so deal with that in a fairly clean manner.
Thanks for your patience with me.

It *should* also solve the cache.log rotate problem on cygwin.

Rob
Received on Tue Aug 14 2001 - 03:14:37 MDT