Re: Some CygWin/Windows fixes

Hi Henrik,

Il 21.45 06/05/2001 Henrik Nordstrom ha scritto:
>Guido Serassio wrote:
>
> > 1) Substitution of #if defined(_SQUID_CYGWIN_) with #if
> > defined(_SQUID_MSWIN_) || defined(_SQUID_CYGWIN_) in files:
> > acl.c, cache_cf.c, cache_diff.c, cf_gen.c, client.c, dns_internal.c,
> > debug.c, mime.c, squid.h, tools.c, store_dir_aufs.c, store_dir_ufs.c
>
>Could we please collapse those into _SQUID_WIN32_ or something similar?

The distinction is needed to handle differences between CygWin and MS
compilers.
It's possible to define a new symbol when both are defined, like
_SQUID_WIN32_, but this can't substitute all the single occurrence of
_SQUID_MSWIN_ and _SQUID_CYGWIN_, so, I don't know if this can be better
for the code maintenance.

Let me know Your opinion.

Guido

> > Plus, I have found a compile conflicts between windows.h and
> > snmp-internal.h on HEAD with --enable-snmp.
> > In CygWin branch I found a Rob's patch to snmp-internal.h that already
> > fixes this conflict.
> >
> > So, I think that is a good idea merge all these changes on HEAD.
>
>Ok. Robert, feel like sorting out what to merge and not?
>
>--
>Henrik

-
=======================================================
Serassio Guido
Via Albenga, 11/4 10134 - Torino - ITALY
Tel. : +39.011.610749
E-mail: serassio@interfree.it
             serassio@libero.it
WWW: http://www.serassio.it
Received on Sun May 06 2001 - 14:07:11 MDT