Re: Squid CygWin enhancement

----- Original Message -----
From: "Robert Collins" <robert.collins@itdomain.com.au>
To: <squid-dev@squid-cache.org>; "Guido Serassio" <serassio@libero.it>
Sent: Friday, April 27, 2001 8:25 AM
Subject: Re: Squid CygWin enhancement

> ----- Original Message -----
> >
> > >1) in defines.h, you are defining _WIN_OS_WIN32S/9X/NT/2K - are
these
> > >constants tested against the OS? If so should we use the
equivalents
> > >from windows.h (or files that windows.h auto-includes) ?
> >
> > These defines are my arbitrary defines, taken from a my code running
> on 9x,
> > NT and 2000 with
> > the GetOSVersion function. There is no useful defines about OS
> recognition
> > on MS (or CygWin compatible) include files, so i think this code may
> be rigth.
> >

These look similar

#define VOS__BASE 0
#define VOS__WINDOWS16 1
#define VOS__PM16 2
#define VOS__PM32 3
#define VOS__WINDOWS32 4

(from winver.h).

We should not use arbitrary defines - while the current os's won't
change, future maintainers won't know how to ID the next version..

Rob
Received on Thu Apr 26 2001 - 17:40:11 MDT