Re: memory leak in acl.c

Thanks.

To guard from these types of errors, the "default:" case has been killed
from the appropriate switch statemets. This way GCC will warn if there
is any missing cases.

Things found by doing this:

* We apparently have a src_rtt ACL type, but no code for matching such
acl's or any documentation on it's usage..

* ACL_REQ/REP_MIME_TYPE was missing from the dump function as well.

More problems are likely to be found when testing different configure
configurations..

/Henrik

Robert Collins wrote:
>
> Index: acl.c
> ===================================================================
> RCS file: /cvsroot/squid/squid/src/acl.c,v
> retrieving revision 1.21
> diff -u -r1.21 acl.c
> --- acl.c 2001/02/09 19:52:05 1.21
> +++ acl.c 2001/02/18 08:33:05
> @@ -2047,6 +2047,8 @@
> case ACL_BROWSER:
> case ACL_SRC_DOM_REGEX:
> case ACL_DST_DOM_REGEX:
> + case ACL_REP_MIME_TYPE:
> + case ACL_REQ_MIME_TYPE:
> aclDestroyRegexList(a->data);
> break;
> case ACL_PROTO:
>
> says it all really.
Received on Sun Feb 18 2001 - 04:17:24 MST