Re: [bmd@mp3.com: Re: doublecheck patches .]

On Mon, Nov 13, 2000, Duane Wessels wrote:
>
>
> On Mon, 13 Nov 2000, Adrian Chadd wrote:
>
> >
> > Here are a new set of patches which I remember being posted to squid-dev
> > a couple of months back, but nothing happened.
>
> > static void
> > parse_peer(peer ** head)
> > {
> > char *token = NULL;
> > peer *p;
> > int i;
> > sockaddr_in_list *s;
> > - const char *me = null_string; /* XXX */
> > + const char *me = getMyHostname();
> > p = memAllocate(MEM_PEER);
> > p->http_port = CACHE_HTTP_PORT;
> > p->icp.port = CACHE_ICP_PORT;
> > p->weight = 1;
> > p->stats.logged_state = PEER_ALIVE;
> > if ((token = strtok(NULL, w_space)) == NULL)
> > self_destruct();
>
> The commit log for this change says
>
> char *me = getMyHostname() breaks strtok on irix-6?
>
> Not very informative. Maybe getMyHostname() used strtok() in the past
> and that trashed the later call in parse_peer().
>
> It would be good if someone has access to an IRIX-6.x box and
> could verify that the above change no longer breaks the
> strtok call later.
>

Strangely enough, I've just upgraded an Indy here.

IRIX distributed 6.2 03131015 IP22

Slow, but I'll try a run of IRIX 6.2 with the MipsPRO compiler suite.
Changes are I can just do a typecast (eww) or break up that into
a define and assignment over two lines.

adrian

-- 
Adrian Chadd			"God: Damn! I left pot everywhere!
<adrian@creative.net.au>	  Now I'll have to create Republicans!"
				    - Bill Hicks