Re: MemPools rewrite

Andres Kroonmaa wrote:
> I've implemented chunked MemPools, split it into lib/MemPool.c and
> src/MemPoolStats.c. So mempools can now be used in under lib/ also.

Ok, missed you by a day, I guess...
In any case, just in case you still want to glance through my
implementation...
As far as I can remember (it has been awhile), the most important differences
were:
- Different chunksize estimation (possibly worse than yours).
- Better utilisation of identical chunksize-pools.

I've sent this to the list in June 1999. Sadly, things were never picked
up by anyone on the development team back then. In reading through one year
worth of squid-dev archive, I find that gradually people have been reinventing
the wheel and bits and pieces have been implemented, memory leaks I found have
been discovered eventually (I haven't verified them all again, so some might
still be left in there which had been fixed in my diffs).

Anyway, I'm still using that server version quite succesfully, and was about
to check into the newer releases and possibly port over some of the things
from my older patches (mostly memory footprint reductions, and startup
improvements to prevent cache-corruption).

Please note that the patches I made, were more of the minimum-change type,
in order to reduce the size of the diffs and keep the changes conceptually
well understood. Large architectural changes which cleaned up the patches
were planned, but only after getting approval about integrating things
with the mainstream version of Squid. Since I never got that approval,
I never bothered to clean things up.

-- 
Sincerely,                                                          srb@cuci.nl
           Stephen R. van den Berg (AKA BuGless).
Gravity is running out!  Conserve gravity: walk with a light step, use tape,
magnets or glue instead of paperweights, avoid showers... take baths instead.