store.log bloat possible fix?

From: Adrian Chadd <adrian@dont-contact.us>
Date: Wed, 4 Oct 2000 13:15:23 +0800

I forget the reasons I threw a storeRelease() in there, but from my
quick testing locally its not needed as above it is a storeReleaseRequest().
Can someone actually tackle this and make sure this doesn't screw up
rebuilds ?

The trouble with calling storeRelease() is that it calls storeLog() and
whilst rebuilding it causes store.log to be VERY full.

Comments?

Adrian

Index: fs/aufs/store_dir_aufs.c
===================================================================
RCS file: /server/cvs-server/squid/squid/src/fs/aufs/store_dir_aufs.c,v
retrieving revision 1.7
diff -u -r1.7 store_dir_aufs.c
--- fs/aufs/store_dir_aufs.c 2000/06/27 22:06:23 1.7
+++ fs/aufs/store_dir_aufs.c 2000/10/04 05:11:42
@@ -566,7 +566,6 @@
                     e->swap_filen = -1;
                     e->swap_dirn = -1;
                 }
- storeRelease(e);
                 rb->counts.objcount--;
                 rb->counts.cancelcount++;
             }
Index: fs/diskd/store_dir_diskd.c
===================================================================
RCS file: /server/cvs-server/squid/squid/src/fs/diskd/store_dir_diskd.c,v
retrieving revision 1.17
diff -u -r1.17 store_dir_diskd.c
--- fs/diskd/store_dir_diskd.c 2000/10/03 15:31:40 1.17
+++ fs/diskd/store_dir_diskd.c 2000/10/04 05:11:47
@@ -754,7 +754,6 @@
                     e->swap_filen = -1;
                     e->swap_dirn = -1;
                 }
- storeRelease(e);
                 rb->counts.objcount--;
                 rb->counts.cancelcount++;
             }
Index: fs/ufs/store_dir_ufs.c
===================================================================
RCS file: /server/cvs-server/squid/squid/src/fs/ufs/store_dir_ufs.c,v
retrieving revision 1.7
diff -u -r1.7 store_dir_ufs.c
--- fs/ufs/store_dir_ufs.c 2000/06/27 22:06:26 1.7
+++ fs/ufs/store_dir_ufs.c 2000/10/04 05:11:50
@@ -566,7 +566,6 @@
                     e->swap_filen = -1;
                     e->swap_dirn = -1;
                 }
- storeRelease(e);
                 rb->counts.objcount--;
                 rb->counts.cancelcount++;
             }

----- End forwarded message -----

-- 
Adrian Chadd			"If a butterfly flaps its wings in China,
<adrian@creative.net.au>	    will a women get naked in Amsterdam?"
				      -- Ashley Penney on Chaos Theory
Received on Tue Oct 03 2000 - 23:15:35 MDT

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:12:40 MST