Re: Updated squid 2.3 stable 3 for cygwin

Thanks for your patch.

A few issues:

a) What is that business with #define sys_nerr 136 in util.c? It is not
withing a #ifdef, and it looks like it collides with the __declspec line
a few lines down..

b) Running Squid under cygwin.dll isn't very useful util cygwin.dll
properly supports non-blocking socket I/O. The basic Squid design is
based on non-blocking socket I/O.

c) It would be nice if you based your work on the current development
sources, available via anonymous cvs from cvs.squid-cache.org.

If you are really serious about getting Squid working under the cygwin
toolchain I'll give you a CVS branch on squid.sourceforge.net to play
around in. The speediest path is probably to take the code Romeo
Anghelache wrote for native Win32 support, and update it to the current
sources (already updated to Squid-2.2.STABLE5 in the SourceForge CVS
repository), and then tweak the cygwin toolchain to build Squid without
cygwin.dll (or Squid to bypass it on networking).

--
Henrik Nordstrom
Squid hacker
Robert Collins wrote:
> 
> Hi,
>     I've just joined the development list - I'll be working on cygwin issues
> only (possibly more should time permit...). I've attached a diff to update
> squid 2.3 stable 3's cygwin support. I have edited configure.in so (and I
> quote)
> "Ok. Ditch the configure diff .. tell people they need to run autoconf
> and autoheader to regenerate the configure info after patching."
> I've also created a new file README.cygwin, as I wasn't sure where my notes
> on the remaining brokeness should go. Tell me where, and next time I'll do
> that.
> 
> In the diff I have
> * replaced a hard coded constant in dns_internal with MAX_DNS_INCOMING
> * put a cygwin specific sys_nerr import in util.c
> * added README.cygwin (wasn't sure where the info in there should go)
> * changed the platform detect code in config.h.in and configure.in to
> recognise the new __CYGWIN__ as well as the deprecated __CYGWIN32__
> * in defines.h use the presence of cygwin to set the max_xxx_incoming
> defines to 1 rather than 15,15 and 10 (this is a work around for a blocking
> io isssue.)
> 
> Rob Collins
> 
>     ---------------------------------------------------------------
> 
>                    Name: squid-2.3.stable3_cygwin112.diff
>     Part 1.2       Type: unspecified type (application/octet-stream)
>                Encoding: quoted-printable